[U-Boot] [PATCH 3/4] fs/fat: Correct description of determine_fatent function

Lukasz Majewski l.majewski at samsung.com
Mon Sep 12 13:04:33 CEST 2016


Hi Stefan,

> Current description does not match the function behaviour.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
> ---
>  fs/fat/fat_write.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/fat/fat_write.c b/fs/fat/fat_write.c
> index babe9c8..0583af3 100644
> --- a/fs/fat/fat_write.c
> +++ b/fs/fat/fat_write.c
> @@ -528,7 +528,8 @@ static int set_fatent_value(fsdata *mydata, __u32
> entry, __u32 entry_value) }
>  
>  /*
> - * Determine the entry value at index 'entry' in a FAT (16/32) table
> + * Determine the next free cluster after 'entry' in a FAT (16/32)
> table
> + * and link it to 'entry'. EOC marker is not set on returned entry.
>   */
>  static __u32 determine_fatent(fsdata *mydata, __u32 entry)
>  {
> @@ -537,6 +538,7 @@ static __u32 determine_fatent(fsdata *mydata,
> __u32 entry) while (1) {
>  		next_fat = get_fatent_value(mydata, next_entry);
>  		if (next_fat == 0) {
> +			/* found free entry, link to entry */
>  			set_fatent_value(mydata, entry, next_entry);
>  			break;
>  		}

Acked-by: Lukasz Majewski <l.majewski at samsung.com>

-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list