[U-Boot] [PATCH v3] net: Fix cache misalignment message after network load operations

Heiko Schocher hs at denx.de
Wed Sep 14 06:22:27 CEST 2016


Hello Peter,

Am 14.09.2016 um 05:49 schrieb Peter.Chubb at data61.csiro.au:
> After any operation that downloads a file (e.g., pxe get, or dhcp), the
> buffer containing the downloaded data is flushed.  This is unnecessary
> and annoying.  Unnecessary, because
> the network driver should already have fliushed the cache for the DMAed area,
> and annoying because it generates a cache misalignment message.
>
> Signed-off-by: Peter Chubb <peter.chubb at data61.csiro.au>
> ---
>   cmd/net.c |    3 ---
>   1 file changed, 3 deletions(-)

I posted a fix for this here:
http://patchwork.ozlabs.org/patch/663489/

but I did not remove the flush operation ... can we really remove it?

If so, you can add my
Acked-by: Heiko Schocher <hs at denx.de>

bye,
Heiko
>
> Index: u-boot/cmd/net.c
> ===================================================================
> --- u-boot.orig/cmd/net.c	2016-09-07 13:50:46.616156851 +1000
> +++ u-boot/cmd/net.c	2016-09-07 19:18:18.962450874 +1000
> @@ -243,9 +243,6 @@ static int netboot_common(enum proto_t p
>   		return CMD_RET_SUCCESS;
>   	}
>
> -	/* flush cache */
> -	flush_cache(load_addr, size);
> -
>   	bootstage_mark(BOOTSTAGE_ID_NET_LOADED);
>
>   	rcode = bootm_maybe_autostart(cmdtp, argv[0]);
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list