[U-Boot] does it make sense to define misc_init_r() not conditional on CONFIG_MISC_INIT_R?

[Robert P. J. Day]

  another oddity i noted in my travels ... in common/board_r.c, this:

  #ifdef CONFIG_MISC_INIT_R
        misc_init_r,            /* miscellaneous platform-dependent init */
  #endif

suggests that any *definition* of a board's misc_init_r() routine
should be similarly conditional, but there are well over a hundred
counter-examples like, say, this from km83xx.c:

  int misc_init_r(void)
  {
        ivm_read_eeprom(ivm_content, CONFIG_SYS_IVM_EEPROM_MAX_LEN);
        return 0;
  }

  doesn't hurt, of course ... binary just ends up containing a
superfluous misc_init_r() routine that's never called. i suspect
there's a lot of that with other routines as well.

  or is there something else going on here more subtle that i don't
understand?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================