[U-Boot] [PATCH v2 0/5] Enhance fs tests

Simon Glass sjg at chromium.org
Wed Sep 14 16:22:51 CEST 2016


Hi Tom,

On 14 September 2016 at 07:38, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Sep 14, 2016 at 07:32:47AM -0600, Simon Glass wrote:
>> Hi Stefan,
>>
>> On 13 September 2016 at 17:01, Stefan Brüns
>> <stefan.bruens at rwth-aachen.de> wrote:
>> > The first 3 patches do some cleanups for the current test, especially TC11
>> > had some issues (strange match for expected output, use of unitialized
>> > variable).
>> >
>> > The last two patches add test cases for handling ".". Ext4 used to crash,
>> > as a match on the first entry of a directory block was not handled
>> > correctly.
>>
>> I think we should move these to pytest before enhancing them.
>
> For the moment, I disagree.  We have fs issues, and we're fixing fs
> issues and getting tests while we're doing that is important.  It would
> be good, and would make my (and everyone else that has one too) setup
> easier if these were migrated but I don't want to blocks more tests on
> having them be made into different but equivalent tests first.

Fair enough, I've seen the issues and these are not large additions.

Regards,
Simon


More information about the U-Boot mailing list