[U-Boot] [PATCH 11/13] buildman: Drop the 'active' flag in the builder
Simon Glass
sjg at chromium.org
Mon Sep 19 00:48:36 CEST 2016
This serves no real purpose, since when we are not active, we exit. Drop it.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
tools/buildman/builder.py | 7 -------
tools/buildman/builderthread.py | 10 +---------
2 files changed, 1 insertion(+), 16 deletions(-)
diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index e774c2d..95369f0 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -130,7 +130,6 @@ class Builder:
"""Class for building U-Boot for a particular commit.
Public members: (many should ->private)
- active: True if the builder is active and has not been stopped
already_done: Number of builds already completed
base_dir: Base directory to use for builder
checkout: True to check out source, False to skip that step.
@@ -241,7 +240,6 @@ class Builder:
self.base_dir = base_dir
self._working_dir = os.path.join(base_dir, '.bm-work')
self.threads = []
- self.active = True
self.do_make = self.Make
self.gnu_make = gnu_make
self.checkout = checkout
@@ -401,11 +399,6 @@ class Builder:
if result:
target = result.brd.target
- if result.return_code < 0:
- self.active = False
- command.StopAll()
- return
-
self.upto += 1
if result.return_code != 0:
self.fail += 1
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index a30e4fd..06be5d9 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -478,14 +478,6 @@ class BuilderThread(threading.Thread):
alive = True
while True:
job = self.builder.queue.get()
- if self.builder.active and alive:
+ if alive:
self.RunJob(job)
- '''
- try:
- if self.builder.active and alive:
- self.RunJob(job)
- except Exception as err:
- alive = False
- print err
- '''
self.builder.queue.task_done()
--
2.8.0.rc3.226.g39d4020
More information about the U-Boot
mailing list