[U-Boot] [PATCH] image: Fix expected return value

Simon Glass sjg at chromium.org
Mon Sep 19 02:59:06 CEST 2016


On 16 September 2016 at 06:34, Mario Six <mario.six at gdsys.cc> wrote:
> Commit bac17b7 ("image-fit: switch ENOLINK to ENOENT") changed the
> return value of fit_get_node_from_config from ENOLINK to ENOENT.
>
> This causes a problem in boot_get_ramdisk, which treats the return value
> -ENOLINK differently from other errors (namely, it does not signal a
> failure if -ENOLINK is returned). As a result, booting a FIT image on
> the Armada platform (and possibly others) fails with a "Ramdisk image is
> corrupt or invalid" message, rendering FIT images unusable.
>
> This patch fixes the error by changing the "special" return value in
> boot_get_ramdisk from -ENOLINK to -ENOENT, so that the original behavior
> is restored.
>
> Reviewed-by: Jonathan Gray <jsg at jsg.id.au>
> Signed-off-by: Mario Six <mario.six at gdsys.cc>
> ---
>  common/image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)


More information about the U-Boot mailing list