[U-Boot] [PATCH v2 7/7] mmc: atmel_sdhci: Remove unneccessary clock calling

Jaehoon Chung jh80.chung at samsung.com
Tue Sep 20 09:20:45 CEST 2016


On 09/18/2016 03:53 PM, Wenyou Yang wrote:
> Due to the peripheral and generated clock driver improvement,
> remove the unneccessary clock calling.

s/unneccessary/unnecessary

Also subject.. :)

> 
> Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>

Reviewed-by: Jaehoon Chung <jh80.chung at samsung.com>

Best Regards,
Jaehoon Chung

> ---
> 
> Changes in v2: None
> 
>  drivers/mmc/atmel_sdhci.c | 27 ++-------------------------
>  1 file changed, 2 insertions(+), 25 deletions(-)
> 
> diff --git a/drivers/mmc/atmel_sdhci.c b/drivers/mmc/atmel_sdhci.c
> index dd6bd33..437a652 100644
> --- a/drivers/mmc/atmel_sdhci.c
> +++ b/drivers/mmc/atmel_sdhci.c
> @@ -51,29 +51,6 @@ struct atmel_sdhci_plat {
>  	struct mmc mmc;
>  };
>  
> -static int atmel_sdhci_get_clk(struct udevice *dev, int index, struct clk *clk)
> -{
> -	struct udevice *dev_clk;
> -	int periph, ret;
> -
> -	ret = clk_get_by_index(dev, index, clk);
> -	if (ret)
> -		return ret;
> -
> -	periph = fdtdec_get_uint(gd->fdt_blob, clk->dev->of_offset, "reg", -1);
> -	if (periph < 0)
> -		return -EINVAL;
> -
> -	dev_clk = dev_get_parent(clk->dev);
> -	ret = clk_request(dev_clk, clk);
> -	if (ret)
> -		return ret;
> -
> -	clk->id = periph;
> -
> -	return 0;
> -}
> -
>  static int atmel_sdhci_probe(struct udevice *dev)
>  {
>  	struct mmc_uclass_priv *upriv = dev_get_uclass_priv(dev);
> @@ -86,7 +63,7 @@ static int atmel_sdhci_probe(struct udevice *dev)
>  	struct clk clk;
>  	int ret;
>  
> -	ret = atmel_sdhci_get_clk(dev, 0, &clk);
> +	ret = clk_get_by_index(dev, 0, &clk);
>  	if (ret)
>  		return ret;
>  
> @@ -107,7 +84,7 @@ static int atmel_sdhci_probe(struct udevice *dev)
>  	clk_mul = (caps_1 & SDHCI_CLOCK_MUL_MASK) >> SDHCI_CLOCK_MUL_SHIFT;
>  	gck_rate = clk_base * 1000000 * (clk_mul + 1);
>  
> -	ret = atmel_sdhci_get_clk(dev, 1, &clk);
> +	ret = clk_get_by_index(dev, 1, &clk);
>  	if (ret)
>  		return ret;
>  
> 



More information about the U-Boot mailing list