[U-Boot] [PATCH 2/3] igep00x0: consolidate defconfigs

Tom Rini trini at konsulko.com
Wed Sep 21 01:45:14 CEST 2016


On Wed, Sep 21, 2016 at 12:44:17AM +0200, Ladislav Michl wrote:
> On Tue, Sep 20, 2016 at 08:52:21AM -0400, Tom Rini wrote:
> > On Tue, Sep 20, 2016 at 11:07:57AM +0200, Ladislav Michl wrote:
> > > Update defconfigs and drop NAND specific defconfig as flash type
> > > is runtime detected.
> > > 
> > > Signed-off-by: Ladislav Michl <ladis at linux-mips.org>
> > > ---
> > >  configs/igep0030_defconfig      |  5 ++++-
> > >  configs/igep0030_nand_defconfig | 30 ------------------------------
> > >  configs/igep0032_defconfig      |  4 +++-
> > >  3 files changed, 7 insertions(+), 32 deletions(-)
> > >  delete mode 100644 configs/igep0030_nand_defconfig
> > > 
> > > diff --git a/configs/igep0030_defconfig b/configs/igep0030_defconfig
> > > index 66371d6..eb7a28f 100644
> > > --- a/configs/igep0030_defconfig
> > > +++ b/configs/igep0030_defconfig
> > > @@ -2,7 +2,9 @@ CONFIG_ARM=y
> > >  CONFIG_OMAP34XX=y
> > >  # CONFIG_SPL_EXT_SUPPORT is not set
> > >  CONFIG_TARGET_OMAP3_IGEP00X0=y
> > > -CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0030,BOOT_ONENAND"
> > > +CONFIG_SPL=y
> > > +CONFIG_SYS_EXTRA_OPTIONS="MACH_TYPE=MACH_TYPE_IGEP0020"
> > 
> > Since you're even changing MACH_TYPE here, do we really need to be
> > setting this?  For both defconfigs, even.  Thanks!
> 
> Gah... I have to screw it up while resolving conflicts with upstream changes.
> Obviously MACH_TYPE has to remain the same. Will do v2. I'm sorry for that.

But why do we even need to set MACH_TYPE these days?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160920/7799d768/attachment.sig>


More information about the U-Boot mailing list