[U-Boot] [PATCH] cmd: usb: run 'usb start' when USB is stopped

Simon Glass sjg at chromium.org
Fri Sep 23 06:15:32 CEST 2016


+Marek

On 9 September 2016 at 04:20, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> If USB is stopped, just run 'usb start' instead of printing message.
> Then user didn't consider whether usb is started or stopped.
>
> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
> ---
>  cmd/usb.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cmd/usb.c b/cmd/usb.c
> index 455127c..4970851 100644
> --- a/cmd/usb.c
> +++ b/cmd/usb.c
> @@ -651,8 +651,8 @@ static int do_usb(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>                 return 0;
>         }
>         if (!usb_started) {
> -               printf("USB is stopped. Please issue 'usb start' first.\n");
> -               return 1;
> +               printf("USB is stopped. Running 'usb start' first.\n");
> +               do_usb_start();
>         }
>         if (strncmp(argv[1], "tree", 4) == 0) {
>                 puts("USB device tree:\n");
> --
> 1.9.1
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list