[U-Boot] [PATCH 2/2] input: specify the default of I8042_KEYB in more correct manner

[Simon Glass]

On 19 September 2016 at 06:46, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> 2016-09-19 9:57 GMT+09:00 Simon Glass <sjg at chromium.org>:
>> Hi Masahiro,
>>
>> On 8 September 2016 at 03:47, Masahiro Yamada
>> <yamada.masahiro at socionext.com> wrote:
>>> Creating multiple entries of "config FOO" often gives us bad
>>> experiences.  In this case, we should specify "default X86"
>>> as platforms that want this keyboard by default.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
>>> ---
>>>
>>>  arch/x86/Kconfig      | 3 ---
>>>  drivers/input/Kconfig | 1 +
>>>  2 files changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>>> index 9207549..ac2d598 100644
>>> --- a/arch/x86/Kconfig
>>> +++ b/arch/x86/Kconfig
>>> @@ -546,9 +546,6 @@ config I8254_TIMER
>>>           Intel 8254 timer contains three counters which have fixed uses.
>>>           Include this to have U-Boot set up the timer correctly.
>>>
>>> -config I8042_KEYB
>>> -       default y
>>> -
>>>  config SEABIOS
>>>         bool "Support booting SeaBIOS"
>>>         help
>>> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
>>> index d560328..b3873c1 100644
>>> --- a/drivers/input/Kconfig
>>> +++ b/drivers/input/Kconfig
>>> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
>>>  config I8042_KEYB
>>>         bool "Enable Intel i8042 keyboard support"
>>>         depends on DM_KEYBOARD
>>> +       default X86
>>
>> What does this mean?
>
>
> The default value of I8042_KEYB is the
> value of X86.
>
>
> In another expression,
>
>            default y if X86

Ah OK, thanks.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon