[U-Boot] [PATCH] net: smsc95xx: fix DM MAC address reading

Joe Hershberger joe.hershberger at gmail.com
Fri Sep 23 19:43:39 CEST 2016


On Fri, Sep 23, 2016 at 11:31 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 09/15/2016 01:20 PM, Joe Hershberger wrote:
>>
>> On Thu, Sep 15, 2016 at 1:53 PM, Stephen Warren <swarren at wwwdotorg.org>
>> wrote:
>>>
>>> From: Stephen Warren <swarren at nvidia.com>
>>>
>>> eth-uclass.c expects DM-capable Ethernet adapters to implement ops->
>>> read_rom_hwaddr(), or for some other mechanism to set pdata->enetaddr, or
>>> for the user to set environment variable $usbethaddr. Without any of
>>> these, it will refuse to initialize the device since no valid MAC address
>>> is known. Implement this function for the smsc95xx driver.
>>>
>>> With this feature implemented, there is no point smsc95xx_init_common()
>>> re-reading the MAC address from ROM, so ifdef out this code when DM_ETH
>>> is enabled.
>>>
>>> This allows (at least) the built-in Ethernet on the NVIDIA Harmony board
>>> to operate again.
>>>
>>> Fixes: 0990fcb77219 ("net: smsc95xx: Add driver-model support")
>>> Signed-off-by: Stephen Warren <swarren at nvidia.com>
>>
>>
>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>
>
> Joe, was that ack just so you remember you've reviewed this when you come to
> applying patches later, or was it a signal to someone else that they should
> apply it?

No, I'll pull it in.

Cheers,
-Joe


More information about the U-Boot mailing list