[U-Boot] [PATCH v2 1/3] arm: mvebu: create generic 88F6820 config option

[Chris Packham]

Hi Stefan,

On Sat, Sep 24, 2016 at 8:09 PM, Stefan Roese <sr at denx.de> wrote:
> On 22.09.2016 02:56, Chris Packham wrote:
>>
>> 88F6820 is a specific Armada-38x chip that is used on the DB-88F6820-GP
>> board. Rather than having DB_88F6820_GP and TARGET_DB_88F6820_GP which
>> selects the former. Rename DB_88F6820_GP to 88F6820 so that other boards
>> using the 88F6820 can be added.
>>
>> Signed-off-by: Chris Packham <judge.packham at gmail.com>
>> ---
>>
>> Changes in v2: None
>
>
> Changed for clearfog here as well while applying.
>

I didn't notice clearfog when I was looking. One potential side-effect
of my change for the clearfog board is that mv_board_id_get() will now
return 0 instead of DB_68XX_ID (0x11). I'm not sure what the
consequences of this are. The AMC board works fine with 0 and
DB_68XX_ID is probably wrong for a board that is not the
db-88f6820-gp. On the other hand the AMC board isn't using a number of
peripherals so I may not have noticed a breakage.

If this does turn out to be a problem the following should be
equivalent to the way things were before (sorry can't send a proper
patch having remote access issues).

--- 8< ---
diff --git a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
index 49d704a..cc3e5e2 100644 (file)
--- a/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
+++ b/arch/arm/mach-mvebu/serdes/a38x/sys_env_lib.c
@@ -45,7 +45,7 @@ u32 g_dev_id = -1;

 u32 mv_board_id_get(void)
 {
-#if defined(CONFIG_TARGET_DB_88F6820_GP)
+#if defined(CONFIG_88F6820)
       return DB_GP_68XX_ID;
 #else