[U-Boot] [RFC PATCH v1] common/console.c: ensure GD_FLG_SILENT is set or cleared

[Simon Glass]

Hi Chris,

On 22 September 2016 at 21:59, Chris Packham <judge.packham at gmail.com> wrote:
> When CONFIG_SILENT_CONSOLE is defined and the default environment has
> silent=1 it is not possible for a user to make the console un-silent if
> the environment is not available when console_init_f() is called (for
> example because the environment is in SPI).
>
> Add a new helper function console_update_silent() and call it from both
> console_init_f() and console_init_r().
>
> Signed-off-by: Chris Packham <judge.packham at gmail.com>
> ---
>
>  common/console.c | 17 +++++++++++++----
>  1 file changed, 13 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>

I'm not completely sure that this is the intended behaviour, but it
seems reasonable. I'd really like to see docs in the README (or
elsewhere) about the effect of the 'silent' env variable...

- Simon