[U-Boot] [PATCH 1/5] check-config: fix wrong comment about how to build whitelist

[Simon Glass]

Hi Masahiro,

On 25 September 2016 at 22:04, Masahiro Yamada
<yamada.masahiro at socionext.com> wrote:
> The command suggested in this comment block is wrong; it would not
> rip off CONFIG options that had already been converted to Kconfig.
>
> Instead, we should use the scripts/build-whitelist.sh tool.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>
> ---
>
>  scripts/check-config.sh | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/check-config.sh b/scripts/check-config.sh
> index 28c8fe9..6618dfb 100755
> --- a/scripts/check-config.sh
> +++ b/scripts/check-config.sh
> @@ -5,13 +5,8 @@
>  # Check that the u-boot.cfg file provided does not introduce any new
>  # ad-hoc CONFIG options
>  #
> -# You can generate the list of current ad-hoc CONFIG options (those which are
> -# not in Kconfig) with this command:
> -#
> -# export LC_ALL=C LC_COLLATE=C
> -# git grep CONFIG_ |tr ' \t' '\n\n' |sed -n 's/^\(CONFIG_[A-Z0-9_]*\).*/\1/p' \
> -#      |sort |uniq >scripts/config_whitelist.txt;
> -# unset LC_ALL LC_COLLATE
> +# Use scripts/build-whitelist.sh to generate the list of current ad-hoc
> +# CONFIG options (those which are not in Kconfig).

For me the LC setup is needed. Does it work correctly without it for
you? I found that the sorting was wrong.

>
>  # Usage
>  #    check-config.sh <path to u-boot.cfg> <path to whitelist file> <source dir>
> --
> 1.9.1
>

Regards,
Simon