[U-Boot] [PATCH 15/23] gpio: eg20t: Add driver for Intel EG20T GPIO controllers

[Paul Burton]

On Monday, 26 September 2016 18:35:32 BST Simon Glass wrote:
> > +enum {
> > +       REG_IEN         = 0x00,
> > +       REG_ISTATUS     = 0x04,
> > +       REG_IDISP       = 0x08,
> > +       REG_ICLR        = 0x0c,
> > +       REG_IMASK       = 0x10,
> > +       REG_IMASKCLR    = 0x14,
> > +       REG_PO          = 0x18,
> > +       REG_PI          = 0x1c,
> > +       REG_PM          = 0x20,
> 
> How about using a struct?

Hi Simon,

Interesting - I was told over here[1] that using structs for register access was "deprecated".

[1] https://www.mail-archive.com/u-boot@lists.denx.de/msg220500.html[1]

...so I actually converted the driver away from that style before submitting. Yet both 
yourself & Bin have suggested it - shall I take it that it's not deprecated after all?

Thanks,
    Paul

--------
[1] https://www.mail-archive.com/u-boot@lists.denx.de/msg220500.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160927/52469c54/attachment.sig>