[U-Boot] [PATCH 4/6] ARMv8: Setup PSCI memory and dt

[Hongbo Zhang]

On Wed, Sep 28, 2016 at 12:00 AM, york sun <york.sun at nxp.com> wrote:
> On 09/27/2016 02:29 AM, macro.wave.z at gmail.com wrote:
>> From: Hongbo Zhang <hongbo.zhang at nxp.com>
>>
>> Newly add ARMv8 PSCI needs to be initialized, be copied or reserved in right
>> place, this patch does all the setup steps.
>>
>> Signed-off-by: Hongbo Zhang <hongbo.zhang at nxp.com>
>> ---
>>  arch/arm/cpu/armv8/cpu-dt.c   | 10 ++++++++++
>>  arch/arm/cpu/armv8/cpu.c      | 22 ++++++++++++++++++++++
>>  arch/arm/include/asm/secure.h |  2 +-
>>  arch/arm/include/asm/system.h | 11 +++++++++++
>>  arch/arm/lib/bootm-fdt.c      |  3 ++-
>>  arch/arm/lib/bootm.c          |  3 +++
>>  arch/arm/lib/psci-dt.c        |  5 +++--
>>  7 files changed, 52 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/cpu/armv8/cpu-dt.c b/arch/arm/cpu/armv8/cpu-dt.c
>> index 659ec27..753e21f 100644
>> --- a/arch/arm/cpu/armv8/cpu-dt.c
>> +++ b/arch/arm/cpu/armv8/cpu-dt.c
>> @@ -6,6 +6,7 @@
>>
>>  #include <common.h>
>>  #include <asm/psci.h>
>> +#include <asm/system.h>
>>  #ifdef CONFIG_ARMV8_SEC_FIRMWARE_SUPPORT
>>  #include <asm/armv8/sec_firmware.h>
>>  #endif
>> @@ -27,5 +28,14 @@ int psci_update_dt(void *fdt)
>>       fdt_psci(fdt);
>>  #endif
>>  #endif
>> +
>> +#ifdef CONFIG_ARMV8_PSCI
>> +     fdt_psci(fdt);
>> +#ifndef CONFIG_ARMV8_SECURE_BASE
>
> Is this backward?

Hi York,

I'm sorry not so clear about your concern.
CONFIG_ARMV8_SECURE_BASE, this macro is only for generic ARMv8 PSCI,
not for NXP private PSCI in PPA firmware.

Please feel free to raise concerns / doubts if any.

Thanks.
>
>> +     /* secure code lives in RAM, keep it alive */
>> +     fdt_add_mem_rsv(fdt, (unsigned long)__secure_start,
>> +                     __secure_end - __secure_start);
>> +#endif
>> +#endif
>>       return 0;
>>  }
>
>
> York
>