[U-Boot] [PATCH] usb:gadget: Disallow DFU in SPL for now

Lukasz Majewski l.majewski at samsung.com
Wed Sep 28 11:19:36 CEST 2016


Hi Tom,

> Previously, DFU was not built in for SPL and often disabled via the
> board config.h file, in the SPL build.  By moving DFU to Kconfig we
> now need to move this logic to the Makefile to continue to allow
> boards to fit within their SPL size limit (until gcc 6 is more
> widespread and unused strings will be discarded).
> 
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Without this, but everything converted am335x_evm_usbspl fails to
> link (does gadget USB in SPL) unless we make drivers/dfu/
> unconditional.  This however breaks a few other platforms that have a
> smaller SPL size due to undiscarded strings, and a lot of other
> platforms just grow by a few KiB.  This is the best solution I can
> come up with for now.

Ok, lets disable it (hopefully for now).

> 
>  drivers/usb/gadget/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> index c915c79..acc9964 100644
> --- a/drivers/usb/gadget/Makefile
> +++ b/drivers/usb/gadget/Makefile
> @@ -19,7 +19,9 @@ obj-$(CONFIG_USB_GADGET_FOTG210) += fotg210.o
>  obj-$(CONFIG_CI_UDC)	+= ci_udc.o
>  obj-$(CONFIG_USB_GADGET_DOWNLOAD) += g_dnl.o
>  obj-$(CONFIG_USB_FUNCTION_THOR) += f_thor.o
> +ifndef CONFIG_SPL_BUILD
>  obj-$(CONFIG_USB_FUNCTION_DFU) += f_dfu.o
> +endif
>  obj-$(CONFIG_USB_FUNCTION_MASS_STORAGE) += f_mass_storage.o
>  obj-$(CONFIG_USB_FUNCTION_FASTBOOT) += f_fastboot.o
>  endif



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


More information about the U-Boot mailing list