[U-Boot] [PATCH] dm: ehci-mx6: support driver model

Jagan Teki jagannadh.teki at gmail.com
Thu Sep 29 14:08:32 CEST 2016


Hi Peng,

On Mon, Jun 20, 2016 at 7:15 AM, Peng Fan <van.freenix at gmail.com> wrote:
> Hi Simon,
>
> On Fri, Jun 17, 2016 at 04:59:49PM -0600, Simon Glass wrote:
>>Hi Peng,
>>
>>On 17 June 2016 at 00:19, Peng Fan <van.freenix at gmail.com> wrote:
>>> Support driver model for ehci mx6 driver.
>>> Consolidate code to be shared between DM and non-DM, such as
>>> introducing ehci_mx6_common_init.
>>> For simplicity, some old fasion code are keeped for DM usage,
>>> such as board_ehci_power and board_usb_phy_mode. And 'dr-mode',
>>> usbphy and vbus handling code for DM is not added now.
>>> These will be added in future patches.
>>>
>>> Signed-off-by: Peng Fan <peng.fan at nxp.com>
>>> Cc: Marek Vasut <marex at denx.de>
>>> Cc: Mateusz Kulikowski <mateusz.kulikowski at gmail.com>
>>> Cc: Stefan Agner <stefan at agner.ch>
>>> Cc: Simon Glass <sjg at chromium.org>
>>> ---
>>>  drivers/usb/host/ehci-mx6.c | 144 +++++++++++++++++++++++++++++++++++++++-----
>>>  1 file changed, 130 insertions(+), 14 deletions(-)
>>
>>Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>>Good start. Do you have a plan to drop the board_...() functions?
>
> Yeah. I'll drop the board_ functions for dt+dm for ehci-mx6 in following
> up patches.

Have you tested this? Do we have any board that using this dm driver.
It's not working for me may be I would have add vbus-supply or
something.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.


More information about the U-Boot mailing list