[U-Boot] [RFC] Question about nfs_read_reply()

Jaehoon Chung jh80.chung at samsung.com
Mon Apr 10 10:23:08 UTC 2017


Dear Joe,

I have a question about nfs.
I don't have a knowledge for NFS..So i don't know this is right or not..

When i have tested the latest u-boot(v2017.03), nfs doesn't work fine with Odroid-xu3.

My question is a below thing...In net/nfs.c, nfs_read_reply() function is called the memcpy().
it should be copied the sizeof(rpc_pkt.u.reply))...is it really right?

diff --git a/net/nfs.c b/net/nfs.c
index 83ed0a7..09556c7 100644
--- a/net/nfs.c
+++ b/net/nfs.c
@@ -660,7 +660,8 @@ static int nfs_read_reply(uchar *pkt, unsigned len)

        debug("%s\n", __func__);

       memcpy(&rpc_pkt.u.data[0], pkt, sizeof(rpc_pkt.u.reply));


When i changed from "sizeof(rpc_pkt.u.reply)" to "len", it was working fine.

Maybe i'm wrong..so i asked this to you...

Best Regards,
Jaehoon Chung


More information about the U-Boot mailing list