[U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier

[Andy Shevchenko]

On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> Hi Andy,
> 
> > From: Felipe Balbi <felipe.balbi at linux.intel.com>
> > 
> > Add watchdog driver for Intel Tangier based platforms.
> > 
> > Signed-off-by: Vincent Tinelli <vincent.tinelli at intel.com>
> > Signed-off-by: Felipe Balbi <felipe.balbi at linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > ---
> >  common/board_f.c               |  1 +
> >  drivers/watchdog/Kconfig       |  8 ++++++
> >  drivers/watchdog/Makefile      |  1 +
> >  drivers/watchdog/tangier_wdt.c | 63
> > ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 73
> > insertions(+) create mode 100644 drivers/watchdog/tangier_wdt.c
> > 
> > diff --git a/common/board_f.c b/common/board_f.c
> > index d9431ee79a..ad1eae98a5 100644
> > --- a/common/board_f.c
> > +++ b/common/board_f.c
> > @@ -91,6 +91,7 @@ static int init_func_watchdog_init(void)
> >  	(defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || \
> >  	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG) ||
> > \
> >  	defined(CONFIG_DESIGNWARE_WATCHDOG) || \
> > +	defined(CONFIG_TANGIER_WATCHDOG) || \
> >  	defined(CONFIG_IMX_WATCHDOG))
> 
> I have stumbled upon similar patch... There should be new Kconfig
> option created and enabled in required SoCs.

I'm glad to use one if there is one.
For now I prefer to have it functional.

> The code seems OK, but recently patches to add wdt-uclass has been
> posted:
> 
> http://patchwork.ozlabs.org/patch/751448/
> http://patchwork.ozlabs.org/patch/751451/
> 
> Maybe it would be better to port this driver to the uclass from the
> very beginning?

Good point. Will do.

-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy