[U-Boot] [PATCH v1] watchdog: Introduce watchdog driver for Intel Tangier

[Tom Rini]

On Tue, Apr 18, 2017 at 05:57:31PM +0300, Andy Shevchenko wrote:
> On Tue, 2017-04-18 at 16:49 +0200, Lukasz Majewski wrote:
> > Hi Andy,
> > 
> > > From: Felipe Balbi <felipe.balbi at linux.intel.com>
> > > 
> > > Add watchdog driver for Intel Tangier based platforms.
> > > 
> > > Signed-off-by: Vincent Tinelli <vincent.tinelli at intel.com>
> > > Signed-off-by: Felipe Balbi <felipe.balbi at linux.intel.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> > > ---
> > >  common/board_f.c               |  1 +
> > >  drivers/watchdog/Kconfig       |  8 ++++++
> > >  drivers/watchdog/Makefile      |  1 +
> > >  drivers/watchdog/tangier_wdt.c | 63
> > > ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 73
> > > insertions(+) create mode 100644 drivers/watchdog/tangier_wdt.c
> > > 
> > > diff --git a/common/board_f.c b/common/board_f.c
> > > index d9431ee79a..ad1eae98a5 100644
> > > --- a/common/board_f.c
> > > +++ b/common/board_f.c
> > > @@ -91,6 +91,7 @@ static int init_func_watchdog_init(void)
> > >  	(defined(CONFIG_M68K) || defined(CONFIG_MICROBLAZE) || \
> > >  	defined(CONFIG_SH) || defined(CONFIG_AT91SAM9_WATCHDOG) ||
> > > \
> > >  	defined(CONFIG_DESIGNWARE_WATCHDOG) || \
> > > +	defined(CONFIG_TANGIER_WATCHDOG) || \
> > >  	defined(CONFIG_IMX_WATCHDOG))
> > 
> > I have stumbled upon similar patch... There should be new Kconfig
> > option created and enabled in required SoCs.
> 
> I'm glad to use one if there is one.
> For now I prefer to have it functional.

We have time to get this right.  Looking at the code context,
CONFIG_HW_WATCHDOG_ENABLE, and some help text saying that it enables the
hardware watchdog during U-Boot's initialization process would be
enough.  Then select that in your next patch and you can leave the rest
of the conversion for later.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170418/9fe36ea0/attachment.sig>