[U-Boot] [PATCH 3/3] spl: dfu: reduce spl-dfu MLO size

B, Ravi ravibabu at ti.com
Thu Apr 27 11:21:59 UTC 2017


{Corrected typo u-boot mailing list.}

Hi Lukasz

>> Since spl-dfu does not dfu-reset, there is no need of 
>> run_command_cli, hence compiling out cli.c and cli_hush.c to reduce 
>> the spl-dfu memory foot print.
>> 
[..]
>>   */
>> -#ifdef CONFIG_DFU_TFTP
>> +#if defined(CONFIG_DFU_TFTP) && !defined(CONFIG_SPL_BUILD)

>And then somebody would like to use DFU TFTP in the SPL (like you use 
>DFU) and we would have new set of problems.

>Sorry, but this is a wrong approach. 

I agree with you for TFTP use-case. 
But as aligned, in order to reduce SPL size, use SPL-DFU to load and execute u-boot from RAM.
And then use complete DFU facility in u-boot for flashing MMC/SF/NAND etc.

I don't see any harm to allow for DFU_TFTP in SPL. 
And SPL shall not support CONFIG_DFU_{MMC/NAND/SF} or any memory device except DFU_RAM.

Regards
Ravi



More information about the U-Boot mailing list