[U-Boot] [PATCH] sunxi: Explicitly call fdt_fixup_ethernet() in our ft_board_setup()

Maxime Ripard maxime.ripard at free-electrons.com
Fri Apr 28 09:05:46 UTC 2017


On Fri, Apr 28, 2017 at 03:33:53PM +0800, Chen-Yu Tsai wrote:
> The sunxi platform relies on the core boot sequence to load and process
> device tree blobs, including writing back any MAC addresses we generate
> by an implicit call to fdt_fixup_ethernet() within the image loading
> mechanism. This call was removed in commit 3f66149d9fb4 ("Remove extra
> fdt_fixup_ethernet() call"), resuling in Linux using random MAC
> addresses.
> 
> This patch adds an explicit call to fdt_fixup_ethernet() in our
> ft_board_setup() function.
> 
> Fixes: 3f66149d9fb4 ("Remove extra fdt_fixup_ethernet() call")

I would just revert that commit. The function mentionned in the commit
log is platform specific, it just doesn't make any sense to remove
some generic code just because it would work on your platform.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170428/65a3f02c/attachment.sig>


More information about the U-Boot mailing list