[U-Boot] [PATCH] sunxi: Explicitly call fdt_fixup_ethernet() in our ft_board_setup()

[Tom Rini]

On Fri, Apr 28, 2017 at 11:05:46AM +0200, Maxime Ripard wrote:
> On Fri, Apr 28, 2017 at 03:33:53PM +0800, Chen-Yu Tsai wrote:
> > The sunxi platform relies on the core boot sequence to load and process
> > device tree blobs, including writing back any MAC addresses we generate
> > by an implicit call to fdt_fixup_ethernet() within the image loading
> > mechanism. This call was removed in commit 3f66149d9fb4 ("Remove extra
> > fdt_fixup_ethernet() call"), resuling in Linux using random MAC
> > addresses.
> > 
> > This patch adds an explicit call to fdt_fixup_ethernet() in our
> > ft_board_setup() function.
> > 
> > Fixes: 3f66149d9fb4 ("Remove extra fdt_fixup_ethernet() call")
> 
> I would just revert that commit. The function mentionned in the commit
> log is platform specific, it just doesn't make any sense to remove
> some generic code just because it would work on your platform.

It's not quite that easy.  Part of the issue here is that in PowerPC we
expect to have ft_cpu_setup and ft_board_setup populated and performing
various fix-ups.

That said, 3f66149d9fb4 is fixing a problem we introduced in
13d06981a982.  But, lets try again, Joakim, what is the problem of
calling fdt_fixup_ethernet a second time?  And why not just drop the
call from the other locations?  I don't see a problem with that, in a
quick read over of the other callers.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170428/a63d68b3/attachment.sig>