[U-Boot] [PATCH 2/3] rockchip: set Pre-reloc malloc pool size to 4kb for rk3368 based boards

Andreas Färber afaerber at suse.de
Wed Aug 2 13:27:13 UTC 2017


Am 02.08.2017 um 15:25 schrieb Dr. Philipp Tomsich:
> 
>> On 02 Aug 2017, at 15:10, Andy Yan <andy.yan at rock-chips.com> wrote:
>>
>> The default 1kb pre-reloc malloc pool is not enough for dm
>> core to enable the dm-pre-reloc device drivers.
>>
>> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
>>> 
> Acked-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> 
> See comment below.
> 
>>
>> configs/evb-px5_defconfig      | 1 +
>> configs/geekbox_defconfig      | 1 +
>> configs/sheep-rk3368_defconfig | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/configs/evb-px5_defconfig b/configs/evb-px5_defconfig
>> index dae5094..72e492f 100644
>> --- a/configs/evb-px5_defconfig
>> +++ b/configs/evb-px5_defconfig
>> @@ -1,5 +1,6 @@
>> CONFIG_ARM=y
>> CONFIG_ARCH_ROCKCHIP=y
>> +CONFIG_SYS_MALLOC_F_LEN=0x1000
> 
> We even increased this to 0x2000 for TPL/SPL on the lion-board (i.e. RK3368-uQ7).
> Should we just make 0x2000 the default for RK3368 (in Kconfig) and reduce the noise in defconfig?

Is there any downside to it? If not, I'd say yes.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)


More information about the U-Boot mailing list