[U-Boot] [U-Boot, 5/5] boot: fdt: fixup the memory dt nodes falcon boot

[Jagan Teki]

On Thu, Aug 3, 2017 at 1:02 AM, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Aug 02, 2017 at 07:10:51PM +0000, York Sun wrote:
>> On 04/18/2017 04:57 AM, B, Ravi wrote:
>> > In single stage bootmode or falcon boot mode,
>> > the SPL shall update the memory dt nodes
>> > spl_fixup_fdt() based on DDR configuration for
>> > specific platform.
>> >
>> > Signed-off-by: Ravi Babu <ravibabu at ti.com>
>> > ---
>> >   common/spl/spl.c | 40 ++++++++++++++++++++++++++++++++++++++++
>> >   1 file changed, 40 insertions(+)
>>
>> Clearly I am late for this thread. I only notice this change when I try
>> to merge my FIT improvement for falcon boot.
>>
>> Why do we need to fixup the device tree for falcon boot at all? The
>> device tree is static, saved as argument when exporting it, isn't it? As
>> far as the normal boot fixes up the device tree, the exported device
>> tree is correct.
>
> So, the further argument here is that if you have to edit the dts to
> include a valid amount of memory so that the dtb the kernel spits out is
> useful in falcon mode, it's not at all useful in development.

Anyone noticed! this change is breaking falcon mode (tried in i.MX6
and rk3288) even if we forcibly disable CONFIG_SPL_OF_LIBFDT the SPL
need to revert back to use SPL_OF_PLATDATA.

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.