[U-Boot] [PATCH v4 0/4] net: phy: Add Broadcom BCM53xx switch driver

[Joe Hershberger]

On Sat, Dec 9, 2017 at 4:59 PM, Florian Fainelli <f.fainelli at gmail.com> wrote:
> Hi all,
>
> This patch series adds support for the Broadcom BCM53xx switches, in particular
> BCM53125 which is found no the Lamobo R1 board.
>
> The driver is largely based on the DSA/b53 driver Linux driver and only
> incorporates what is necessary to succesfully bring-up all ports (including the
> management port) for boot over the network:
>
> => dhcp
> dw_adjust_link: Speed: 1000, full duplex
> BOOTP broadcast 1
> DHCP client bound to address 192.168.0.11 (3 ms)
> Using ethernet at 01c50000 device
> TFTP from server 192.168.0.1; our IP address is 192.168.0.11
> Filename 'sun7i-a20-lamobo-r1-kernel.bin'.
> Load address: 0x42000000
> Loading: #################################################################
>          #################################################################
>          ################################
>          11.6 MiB/s
> done
> Bytes transferred = 2371552 (242fe0 hex)
> =>
>
> Joe there is one warning left which does not look legit to me since we now have
> a help paragraph describing the config symbol:
>
> WARNING: please write a paragraph that describes the config symbol fully
> #34: FILE: drivers/net/phy/Kconfig:15:
> +config B53_SWITCH
>
> and one CHECK left which I intentionally did not fix because it makes the
> definitions of the bits less clear:
> CHECK: Prefer using the BIT macro
> #134: FILE: drivers/net/phy/b53.c:63:
> +#define   PORT_OVERRIDE_SPEED_100M     (1 << PORT_OVERRIDE_SPEED_S)

Works for me.

Cheers,
-Joe

>
> Changes in v4:
> - address most checkpatch.pl issues, couple remaining, one which looks bogus:
>
>
> Changes in v3:
> - dropped redundant phydev->priv assignment in b53_probe(), spotted by Joe
>
> Changes in v2:
>
> - collected Sefan's Reviewed-by and Joe's Acked-by tags
> - use max() in drivers/net/designware.c as suggested by Joe
>
> Florian Fainelli (4):
>   net: phy: Add Broadcom BCM53xx switch driver
>   net: designware: Pad small packets
>   net: phy: b53: Add b53_reg read/write commands
>   configs: Update Lamobo_R1 with B53 switch options
>
> Florian Fainelli (4):
>   net: phy: Add Broadcom BCM53xx switch driver
>   net: designware: Pad small packets
>   net: phy: b53: Add b53_reg read/write commands
>   configs: Update Lamobo_R1 with B53 switch options
>
>  configs/Lamobo_R1_defconfig |   3 +
>  drivers/net/designware.c    |   5 +
>  drivers/net/phy/Kconfig     |  17 +
>  drivers/net/phy/Makefile    |   1 +
>  drivers/net/phy/b53.c       | 768 ++++++++++++++++++++++++++++++++++++++++++++
>  drivers/net/phy/phy.c       |   3 +
>  include/phy.h               |   1 +
>  7 files changed, 798 insertions(+)
>  create mode 100644 drivers/net/phy/b53.c
>
> --
> 2.14.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot