[U-Boot] [PATCH] arm: imx: cx9020: remove usage of mx53_dram_size

Fabio Estevam festevam at gmail.com
Sat Dec 16 18:23:55 UTC 2017


Hi Patrick,

On Fri, Dec 15, 2017 at 10:56 AM,  <linux-kernel-dev at beckhoff.com> wrote:
> From: Patrick Bruenn <p.bruenn at beckhoff.com>
>
> Global variables are not available during board_init_f().
> 'static uint32_t mx53_dram_size[2];' was used in board specific
> dram_init(), dram_init_banksize() and get_effective_memsize() to avoid
> multiple calls to get_ram_size().
>
> However multiple calls are better than undefined behavior...
> This fixes:
> https://lists.denx.de/pipermail/u-boot/2017-November/313214.html
> https://lists.denx.de/pipermail/u-boot/2017-December/314480.html
>
> Signed-off-by: Patrick Bruenn <p.bruenn at beckhoff.com>
>
> ---
>
> mx53cx9020 was based on mx53loco, which still uses this global variable.
> If you agree, this is a bug, I can prepare a similar fix for the QSB.
> Maybe it makes sense to move the dram_init functions for both boards
> into something like boards/freescale/common/mx53_dram.c
> But be aware I have no QSB at hand and could only compile test that
> patch for mx53loco.

Yes, it makes sense to fix all boards. board/aries/m53evk/m53evk.c
would also be affected.

Please prepare a patch that fixes all of them.

Thanks!


More information about the U-Boot mailing list