[U-Boot] [PATCH v2 1/2] board: ge: bx50v3: fix AR8033 reset timing issue

Stefano Babic sbabic at denx.de
Tue Feb 21 15:30:33 UTC 2017


On 21/02/2017 02:56, Ken Lin wrote:
> Add the delay (10ms) to ensure the clock is stable and to meet the clock-to-reset(1ms) requirement recommended in the AR8033 datasheet
> 
> Signed-off-by: Ken Lin <yungching0725 at gmail.com>
> ---
> Changes from v1
> - Fix the missing Signed-off-by issue
> 
>  board/ge/bx50v3/bx50v3.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/board/ge/bx50v3/bx50v3.c b/board/ge/bx50v3/bx50v3.c
> index 2fc1144cda..80b4ba1b8b 100644
> --- a/board/ge/bx50v3/bx50v3.c
> +++ b/board/ge/bx50v3/bx50v3.c
> @@ -103,8 +103,9 @@ static void setup_iomux_enet(void)
>  
>  	/* Reset AR8033 PHY */
>  	gpio_direction_output(IMX_GPIO_NR(1, 28), 0);
> -	udelay(500);
> +	mdelay(10);
>  	gpio_set_value(IMX_GPIO_NR(1, 28), 1);
> +	mdelay(1);
>  }
>  
>  static iomux_v3_cfg_t const usdhc2_pads[] = {
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic

-- 
Meet DENX at the Embedded World Trade Show
14 Mar - 16 Mar 2017, Nuremberg Trade Fair Centre, Hall 4, Booth 581
--
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list