[U-Boot] [PATCH] rockchip: firefly: configs: remove config_spl_of_platdata

Simon Glass sjg at chromium.org
Thu Feb 23 03:35:52 UTC 2017


On 20 February 2017 at 03:28, Jacob Chen <jacobchen110 at gmail.com> wrote:
> Hi,
>
> 2017-02-17 4:44 GMT+08:00 Simon Glass <sjg at chromium.org>:
>> Hi,
>>
>> On 14 February 2017 at 23:41, Jacob Chen <jacob2.chen at rock-chips.com> wrote:
>>> Hi Kever,
>>>
>>>
>>> Kever Yang wrote on 2017年02月15日 14:13:
>>>>
>>>> Hi Jacob,
>>>>
>>>> On 02/15/2017 11:06 AM, Jacob Chen wrote:
>>>>>
>>>>> We should remove config_spl_of_platdata to build u-boot-spl-dtb.bin
>>>>> rather than u-boot-spl-nodtb.bin
>>>>> since we use spl_back_to_brom.
>>>>
>>>>
>>>> Have you try with CONFIG_SPL_OF_PLATDATA on and without SPL_BACK_TO_BROM?
>>>>
>>>> If this works on firefly, then we can still leave it as an example to show
>>>> how both way works.
>>>>
>>>
>>> Firefly had been using CONFIG_SPL_OF_PLATDATA and it works well.
>>> Just it will make trouble for other things to generate the u-boot blob,
>>> like yocto, sdk build scripts, guides...
>>>
>>> At first, I also want to keep  CONFIG_SPL_OF_PLATDATA in firefly, but later
>>> I find that i have to do a lot of unnecessary work to deal with it,
>>> so now I would like one chip use one way to generate the u-boot blob.
>>
>> How about having a separate board config like firefly-rk3288-dt so
>> that we keep the non-of-platdata alive? It only needs a separate
>> defconfig, which is pretty esay.
>>
>> Regards,
>> Simon
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>
>
> I send a  patch "rockchip: firefly: configs: add a new config to keep
> non-of-platdata" to save old config.

OK thanks.

Acked-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list