[U-Boot] [PATCH] mmc: uniphier-sd: fix Kconfig dependency

Jaehoon Chung jh80.chung at samsung.com
Tue Jan 3 02:10:08 CET 2017


On 12/30/2016 11:20 PM, Masahiro Yamada wrote:
> Some MMC drivers describe operations with the DM_MMC_OPS form, but
> there are still several drivers with older implementation.  We can
> not compile drivers from different groups at the same time because
> the core framework is shared with #ifdef CONFIG_DM_MMC_OPS.
> 
> Every driver should have "depends on DM_MMC_OPS" (or !DM_MMC_OPS)
> explicitly to express which framework it is based on.  This will
> avoid enabling drivers with incompatible interface at the same time.
> It is incorrect to make a driver "select DM_MMC_OPS".
> 
> While we are here, add "depends on OF_CONTROL" as well because this
> driver can be configured only by Device Tree.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro at socionext.com>

Applied on u-boot-mmc. Thanks!

Best Regards,
Jaehoon Chung

> ---
> 
>  drivers/mmc/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index ff4344f..75b6ba1 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -107,8 +107,8 @@ config ROCKCHIP_SDHCI
>  config MMC_UNIPHIER
>  	bool "UniPhier SD/MMC Host Controller support"
>  	depends on ARCH_UNIPHIER
> -	depends on BLK
> -	select DM_MMC_OPS
> +	depends on BLK && DM_MMC_OPS
> +	depends on OF_CONTROL
>  	help
>  	  This selects support for the SD/MMC Host Controller on UniPhier SoCs.
>  
> 



More information about the U-Boot mailing list