[U-Boot] [PATCH RESEND v2 1/2] spi: cadence_qspi_apb: Use 32 bit indirect write transaction when possible

Jagan Teki jagan at openedev.com
Wed Jan 4 17:54:09 CET 2017


On Wed, Jan 4, 2017 at 5:43 PM, Marek Vasut <marex at denx.de> wrote:
> On 01/04/2017 05:40 PM, Jagan Teki wrote:
>> On Wed, Jan 4, 2017 at 5:22 PM, Marek Vasut <marex at denx.de> wrote:
>>> On 01/04/2017 04:53 PM, Jagan Teki wrote:
>>>> On Wed, Jan 4, 2017 at 5:02 AM, Vignesh R <vigneshr at ti.com> wrote:
>>>>>
>>>>>
>>>>> On Tuesday 03 January 2017 07:40 PM, Jagan Teki wrote:
>>>>>> On Tue, Jan 3, 2017 at 2:35 PM, R, Vignesh <vigneshr at ti.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> On 12/21/2016 10:42 AM, Vignesh R wrote:
>>>>>>>> According to Section 11.15.4.9.2 Indirect Write Controller of K2G SoC
>>>>>>>> TRM SPRUHY8D[1], the external master is only permitted to issue 32-bit
>>>>>>>> data interface writes until the last word of an indirect transfer
>>>>>>>> otherwise indirect writes is known to fails sometimes. So, make sure
>>>>>>>> that QSPI indirect writes are 32 bit sized except for the last write. If
>>>>>>>> the txbuf is unaligned then use bounce buffer to avoid data aborts.
>>>>>>>>
>>>>>>>> So, now that the driver uses bounce_buffer, enable CONFIG_BOUNCE_BUFFER
>>>>>>>> for all boards that use Cadence QSPI driver.
>>>>>>>>
>>>>>>>> [1]www.ti.com/lit/ug/spruhy8d/spruhy8d.pdf
>>>>>>>>
>>>>>>>> Signed-off-by: Vignesh R <vigneshr at ti.com>
>>>>>>>> Reviewed-by: Marek Vasut <marex at denx.de>
>>>>>>>
>>>>>>> Gentle ping on the series...
>>>>>>
>>>>>> Please link to other one, I couldn't find it on patchwork.
>>>>>>
>>>>>
>>>>> Here are the two patches of the series:
>>>>> https://patchwork.ozlabs.org/patch/707648/
>>>>> https://patchwork.ozlabs.org/patch/707647/
>>>>
>>>> Applied to u-boot-spi/master
>>>
>>> I believe you mean next, right ?
>>
>> master, Since the patch thread start before MW
>>
> I just hope you don't plan to push this into 2017.01 ...

I already send PR for these, since these were sitting so-long. any issues?


More information about the U-Boot mailing list