[U-Boot] [PATCH v3 3/4] mmc: zynq: Determine base clock frequency via clock framework

Jaehoon Chung jh80.chung at samsung.com
Tue Jan 10 10:27:01 CET 2017


Hi Stefan,

On 01/10/2017 06:16 PM, Stefan.Herbrechtsmeier at weidmueller.com wrote:
> Hi Michael
> 
>> -----Ursprüngliche Nachricht-----
>> Von: Michal Simek [mailto:michal.simek at xilinx.com]
>> Gesendet: Dienstag, 6. Dezember 2016 13:59
>> An: Jaehoon Chung; Herbrechtsmeier, Stefan; u-boot at lists.denx.de
>> Cc: Michal Simek; Simon Glass; Albert Aribaud; Michal Simek; Stephen
>> Warren
>> Betreff: Re: [PATCH v3 3/4] mmc: zynq: Determine base clock frequency
>> via clock framework
>>
>> On 5.12.2016 23:22, Jaehoon Chung wrote:
>>> On 12/02/2016 10:24 PM, stefan.herbrechtsmeier at weidmueller.de wrote:
>>>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.de>
>>>>
>>>> The zynq_sdhci controller driver use CONFIG_ZYNQ_SDHCI_MAX_FREQ as
>>>> base clock frequency but this clock is not fixed and depends on the
>>>> hardware configuration. Additionally the value of
>>>> CONFIG_ZYNQ_SDHCI_MAX_FREQ doesn't match the real base clock
>>>> frequency of SDIO_FREQ. Use the clock framework to determine the
>> frequency at run time.
>>>>
>>>> Signed-off-by: Stefan Herbrechtsmeier
>>>> <stefan.herbrechtsmeier at weidmueller.de>
>>>
>>>
>>> Even if this patch is delegated to Michal, i picked to this.
>>> Applied on u-boot-mmc.
>>>
>>
>> Based on my reply in v2 this is not ideal patch
>> http://lists.denx.de/pipermail/u-boot/2016-November/274310.html
>>
>> Not a problem to take these patches should mmc tree but please wait
>> till you have Ack from me.
>>
> Will you ack the patch if I remove the zynq specific code and remove the CONFIG_CLK check with my patch series to move zynq clk driver to DM?

I think you can send the patch[1/4] as the split patch.
Could you resend the patch after rebasing on latest u-boot?
(Because our confusion needs to fix with your patch.)

Then Other patches should be left a matter in Michal.

how about?

> 
> Regards,
>   Stefan
> 
> 
> 
> Kommanditgesellschaft - Sitz: Detmold - Amtsgericht Lemgo HRA 2790 - 
> Komplementärin: Weidmüller Interface Führungsgesellschaft mbH - 
> Sitz: Detmold - Amtsgericht Lemgo HRB 3924; 
> Geschäftsführer: José Carlos Álvarez Tobar, Elke Eckstein, Dr. Peter Köhler, Jörg Timmermann;
> USt-ID-Nr. DE124599660
> 



More information about the U-Boot mailing list