[U-Boot] [PATCH] arm: samsung: goni: use the driver model for max8998

Simon Glass sjg at chromium.org
Thu Jan 12 06:07:47 CET 2017


Hi Jaehoon,

On 27 December 2016 at 15:35, Jaehoon Chung <jh80.chung at samsung.com> wrote:
> Hi,
>
> On 12/27/2016 11:31 PM, Minkyu Kang wrote:
>> Hi,
>>
>> On 27 December 2016 at 17:33, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>>
>>> Remove the "ifndef CONFIG_DM_I2C".
>>> Instead, use the driver model for max8998.
>>>
>>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>>> ---
>>>  board/samsung/goni/goni.c | 61 ++++++++++++++++++++++++------
>>> -----------------
>>>  1 file changed, 31 insertions(+), 30 deletions(-)

This looks good to me. A further step would be to add a regulator
driver, rather than poking the pmic registers directly. But that could
come later.

Regards,
Simon


More information about the U-Boot mailing list