[U-Boot] [PATCH] arm: samsung: goni: use the driver model for max8998

Jaehoon Chung jh80.chung at samsung.com
Thu Jan 12 06:19:59 CET 2017


Hi Simon,

On 01/12/2017 02:07 PM, Simon Glass wrote:
> Hi Jaehoon,
> 
> On 27 December 2016 at 15:35, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>> Hi,
>>
>> On 12/27/2016 11:31 PM, Minkyu Kang wrote:
>>> Hi,
>>>
>>> On 27 December 2016 at 17:33, Jaehoon Chung <jh80.chung at samsung.com> wrote:
>>>
>>>> Remove the "ifndef CONFIG_DM_I2C".
>>>> Instead, use the driver model for max8998.
>>>>
>>>> Signed-off-by: Jaehoon Chung <jh80.chung at samsung.com>
>>>> ---
>>>>  board/samsung/goni/goni.c | 61 ++++++++++++++++++++++++------
>>>> -----------------
>>>>  1 file changed, 31 insertions(+), 30 deletions(-)
> 
> This looks good to me. A further step would be to add a regulator
> driver, rather than poking the pmic registers directly. But that could
> come later.

Yes, I will add a regulator driver for Samsung boards.
Before going next step, i'm doing to convert the driver model(I2C, PMIC) for all Samsung SoC.

There are some boards what don't use DM. goni/universal_c210/trat..
I have already completed the converting DM for those boards, and next step will be the using regulator driver.
(I will send the patches..it needs to apply the previous patches...)

My plan is 

1. Convert DM_PMIC and DM_I2C.
2. Use the regulator driver.
3. Remove the unnecessary legacy drivers

After that, i will consider for UCLASS_CHARGER and UCLASS_MUIC.
(As i checked, it leaves a matter in future work, right?)

Best Regards,
Jaehoon Chung

> 
> Regards,
> Simon
> 
> 
> 



More information about the U-Boot mailing list