[U-Boot] [PATCH 2/7] powerpc, 8xx: Implement GLL2 ERRATA

[Wolfgang Denk]

Dear Christophe,

In message <556dc687-0331-40a6-4260-9f78f6131e47 at c-s.fr> you wrote:
> 
> > The code you are adding here violates basic (modern) programming
> > standards.  To access device registers, proper I/O accessors must be
> > used.  In this case the code should use the clrsetbits_be32() macro.
> 
> Oh right, that's the way it is done in Linux Kernel, I used to be 
> surprised it was not that way in U-Boot. If it is like this now, that's 
> good.

It's been here for ages as well.  It's only really ancient (and not
well maintained) code that does not use it yet.

> > You may now argument that the surrounding code is full of similar
> > examples of obsolete, broken code, and you are just following this
> > (bad) example.
> 
> No, I may argument that the code I'm submitting is not new code but code 
> that was written in 2010, and maybe even before, when we were using ppcboot.

So what? You are submitting it today, to be included into curent
mainline.

> > Are you aware of this process?  How do you think to handle such
> > situations in the future?
> 
> I am now :)
> I'll keep it in mind for the future.

The Correct Thing (TM) to do here is to submit two patches: a first
one to convert the file in question to using I/O accessors, and a
second one to extend the code as needed.

> What the auditors really focus on is the deltas between the COTS (ie the 
> official U-boot release) and the sources we use for them. So it is of 
> our interest to have our changes/fixes properly merged into U-boot.

I'm perplexed.  If that was the case then why did you never care to
minimize such differences?

> > 
> > Can you please make an explixit statement here how you are going to
> > handle this in the future?  [And again, schedule is important, too.]
> 
> My plan is to convert to the use of IO accessors during this week.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The ideal situation is to have massive computing power right at home.
Something that dims the streetlights and shrinks the picture  on  the
neighbours' TVs when you boot it up.