[U-Boot] [PATCH v1] arch/x86: Select USB before selecting host driver

[Andy Shevchenko]

On Wed, Jul 5, 2017 at 8:23 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
> Hi Andy,
>
> On Wed, Jul 5, 2017 at 12:32 AM, Andy Shevchenko
> <andriy.shevchenko at linux.intel.com> wrote:
>> Kbuild complains if USB is not selected before any of host driver.
>>
>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>> warning: (X86) selects USB_EHCI_HCD which has unmet direct dependencies (USB)
>>
>> Select it for X86.
>>
>> Fixes: 64d6ac5bc4a9 ("Kconfig: USB: Migrate CONFIG_USB_EHCI_HCD users to Kconfig")
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
>> ---
>>  arch/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/Kconfig b/arch/Kconfig
>> index d04ab9f177..48a267d314 100644
>> --- a/arch/Kconfig
>> +++ b/arch/Kconfig
>> @@ -95,6 +95,7 @@ config X86
>>         select DM_GPIO
>>         select DM_SPI
>>         select DM_SPI_FLASH
>> +       select USB
>>         select USB_EHCI_HCD
>>         imply CMD_FPGA_LOADMK
>>         imply CMD_GETTIME
>
> I cannot reproduce the warnings you are reporting. Isn't this due to
> your board defconfig file does not include CONFIG_USB?

It doesn't. But this doesn't matter, see below.

Anyone who selects USB host _must_ select USB as well. Since the
selection is under X86 it's not anymore board business.
So, options are:
1) apply my patch
2) remove selection of the host at least for X86.

-- 
With Best Regards,
Andy Shevchenko