[U-Boot] [PATCH v1] arch/x86: Select USB before selecting host driver

[Tom Rini]

On Wed, Jul 05, 2017 at 08:19:27PM +0800, Bin Meng wrote:
> +Marek,
> 
> Hi Andy,
> 
> On Wed, Jul 5, 2017 at 5:36 PM, Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> > On Wed, Jul 5, 2017 at 12:36 PM, Andy Shevchenko
> > <andy.shevchenko at gmail.com> wrote:
> >> On Wed, Jul 5, 2017 at 8:23 AM, Bin Meng <bmeng.cn at gmail.com> wrote:
> >
> >> So, options are:
> >> 1) apply my patch
> >> 2) remove selection of the host at least for X86.
> >
> > 3) move hosts out of "if USB".
> >
> 
> 4) select USB in USB_EHCI_HCD?
> 
> Not sure which option is the best way.

So, to be clear, CONFIG_USB is not used in the code.  It's a
Kconfig-only option we can / should use to make navigation and
dependencies easier.  I would think that USB needs to be enabled for any
USB-related choice to be visible (so things can depends on USB or be
hidden under if USB, depending on overall file context).

So I would expect X86 (and most ARCH_xxx under ARM and other cases) to
at least imply USB, if not select it.

And peeking at the kernel, this maybe should be CONFIG_USB_SUPPORT not
CONFIG_USB, to be clearer?

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170705/29c9d15e/attachment.sig>