[U-Boot] [PATCH v1] cpu: Add Intel Tangier support

[Andy Shevchenko]

On Thu, 2017-04-20 at 17:41 +0800, Bin Meng wrote:
> On Thu, Apr 20, 2017 at 3:23 PM, Andy Shevchenko
> <andy.shevchenko at gmail.com> wrote:
> > On Thu, Apr 20, 2017 at 5:59 AM, Bin Meng <bmeng.cn at gmail.com> 
> > > On Tue, Apr 18, 2017 at 10:21 PM, Andy Shevchenko
> > > <andriy.shevchenko at linux.intel.com> wrote:

> > > > +#define SFI_BASE_ADDR          0x000E0000
> > > > +#define SFI_LENGTH             0x00020000
> > > > +#define SFI_TABLE_LENGTH       16
> > > > +
> > > 
> > > Can you add some comments here? I guess U-Boot on tangier is not
> > > the
> > > 1st stage bootloader. It boots from the 1st stage bootloader and
> > > get
> > > memory information via SFI table which 1st stage bootloader
> > > provides?
> > > 
> 
> Can you confirm if my above comments are correct? If so, please add
> some comments.
> 

I didn't get what you are expecting to see here, what kind of comments?

SFI tables are located in first stage boot ROM / "BIOS" (not exactly,
but it's a good approximation for U-Boot). Above is just a range in a
memory to search for them (like some one may do using /dev/mem in
Linux).


-- 
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy