[U-Boot] [PATCH 0/5] db410c: updates for grub + gfxterm

[Mateusz Kulikowski]

Hi Rob,

On 25.06.2017 01:05, Rob Clark wrote:
> In particular, support for display setup by lk.  This introduces a
> simplefb display driver that uses the framebuffer fdt node populated
> by the firmware[1] for u-boot display support (and, at least for
> what I am working on, more interestingly, EFI GOP support).
[...]
 
> A few related patches so that on db410c we actually use the fdt
> passed by lk (and so that dm/core is clever enough to notice fdt
> nodes under "chosen"), config updates, and related fixes.
[...]

I finally had time to look at patches (this and the earlier series).

Enabling the output is pretty cool - I thought of that myself some time ago.

Question: Do you have non-standard partition layout? 
I have flashed most recent 96boards debian image, but my device doesn't 
have splash partition. (It initializes screen properly, just doesn't display anything)

Question2: Are you sure you have included all the patches?

I've applied this series (also included patches from 2017-06-20), but u-boot 
doesn't parse device tree properly and things like usb cease to work - 
both with your and official lk:

<log>

U-Boot 2017.07-rc3-00015-ga2592ee (Jul 06 2017 - 13:48:40 +0200)
Qualcomm-DragonBoard 410C

DRAM:  986 MiB
MMC:   sdhci at 07824000: 0, sdhci at 07864000: 1
Using default environment

In:    serial
Out:   serial
Err:   serial
Failed to find PMIC pon node. Check device tree
Net:   Net Initialization Skipped
No ethernet found.
Hit any key to stop autoboot:  0 

</log>


On the other hand it works properly with your pre-built binary [1].

I assume the difference may be that you have added proper (instead of fake) device 
tree into mkbootimg - is that the case?


Thanks, 
Mateusz



> 
> [1] https://github.com/robclark/lk/commits/db410c-display
> 
> Rob Clark (5):
>   board/db410c: use fdt passed from lk
>   dm: core: also parse chosen node
>   video: simplefb
>   efi_loader: gop: fixes for CONFIG_DM_VIDEO without CONFIG_LCD
>   configs: db410c: config updates
> 
>  arch/arm/Kconfig                                 |  2 +-
>  board/qualcomm/dragonboard410c/dragonboard410c.c | 16 ++++++
>  cmd/bootefi.c                                    |  2 +-
>  configs/dragonboard410c_defconfig                |  7 +++
>  drivers/core/root.c                              | 22 +++++++-
>  drivers/video/Kconfig                            | 10 ++++
>  drivers/video/Makefile                           |  2 +-
>  drivers/video/simplefb.c                         | 68 ++++++++++++++++++++++++
>  lib/efi_loader/Makefile                          |  1 +
>  lib/efi_loader/efi_gop.c                         |  7 ++-
>  10 files changed, 132 insertions(+), 5 deletions(-)
>  create mode 100644 drivers/video/simplefb.c
>