[U-Boot] [PATCH v3 25/35] dm: tegra: pci: Convert to livetree

[Simon Glass]

Hi Stephen,

On 6 July 2017 at 12:55, Stephen Warren <swarren at wwwdotorg.org> wrote:
>
> On 07/06/2017 11:36 AM, sjg at google.com wrote:
>>
>> Update the tegra pci driver to support a live device tree. Fix the check
>> for nvidia,num-lanes so that an error will actually be detected.
>
>
> Simon,
>
> Something in the latest u-boot-dm/master branch breaks PCI or Ethernet on Jeton TK1 and TX1. I don't know which patch it is. test/py's ping test simply fails due to lack of any Ethernet adapter. I don't see any errors during either boot or the network test setup scripts, which include "pci enum":
>
> TK1 (built-in RTL8169 PCI Ethernet):
> Tegra124 (Jetson TK1) # ping $serverip
> No ethernet found.
> ping failed; host 192.168.100.1 is not alive
> Tegra124 (Jetson TK1) #
>
> TX1 (add-on RTL8169 PCI Ethernet):
> Tegra210 (P2371-2180) # pci enum
> ERROR: tegra-pcie: failed to power on PHY: -110
> at /var/lib/jenkins/workspace/u-boot-denx_uboot_dm-master-build/src/u-boot/drivers/pci/pci_tegra.c:774/tegra_pcie_enable_controller()
> ERROR: tegra-pcie: failed to enable controller
> at /var/lib/jenkins/workspace/u-boot-denx_uboot_dm-master-build/src/u-boot/drivers/pci/pci_tegra.c:1154/pci_tegra_probe()
> Tegra210 (P2371-2180) # setenv autoload no
> Tegra210 (P2371-2180) # dhcp
> No ethernet found.
> Tegra210 (P2371-2180) #
>
> I also retested u-boot/master to make sure there's no test system infrastructure issue (that branch passes), and re-ran the failing test 3 times on TK1 with identical results. Other Tegra boards that I test all seem fine, at least as far as passing test/py.
>
> P.S. I'll be away next week and the week after. Tom Warren may be able to monitor the test system emails, but I don't think I've set him up with access to e.g. retrigger tests etc.; perhaps I should look into that...

As mentioned elsewhere that error (failing to power on PHY) happens
for me always on my TK1 (and has for about a year) because it seems to
have a broken PMIC. I do have a TX1 somewhere but cannot find it
despite much searching.

Obviously I chose Tegra for the livetree work based on Nyan which I
have and which is quick to develop on. I am beginning to regret this
because:

- No one at Nvidia appears to be maintaining the code at present -
e.g. DM enablement, Kconfig versions
- The test report you provides is a signal, but it is not actionable for me
- As above due to broken/lost boards I am not able to test as well as
I originally thought

Is there any way someone at Nvidia could jump into this and work on
bringing mainline up to scratch?

Regards,
Simon