[U-Boot] [PATCH 1/6] sunxi: A64: dts: replace EMAC .dtsi with symlink

Simon Glass sjg at chromium.org
Fri Jul 7 03:58:39 UTC 2017


Hi Andre,

On 2 July 2017 at 18:59, Andre Przywara <andre.przywara at arm.com> wrote:
> Currently we add the U-Boot specific Ethernet MAC DT nodes for the
> Pine64 via a board-specific add-on .dtsi.
> However these nodes and properties in there are actually pretty generic
> for all A64 boards which use a PHY connected via RGMII.
> Rename the add-on .dtsi to reflect this and make the Pine64 .dtsi a
> symlink to this new file.
> This simplifies letting other boards use the EMAC too.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> ---
>  arch/arm/dts/sun50i-a64-pine64-plus-u-boot.dtsi | 51 +------------------------
>  arch/arm/dts/sun50i-a64-rgmii-emac.dtsi         | 50 ++++++++++++++++++++++++
>  2 files changed, 51 insertions(+), 50 deletions(-)
>  mode change 100644 => 120000 arch/arm/dts/sun50i-a64-pine64-plus-u-boot.dtsi
>  create mode 100644 arch/arm/dts/sun50i-a64-rgmii-emac.dtsi

It seems odd to use the U-Boot dtsi feature to add code that should be
in the kernel .dts also. Can we instead just #include it?

- Simon


More information about the U-Boot mailing list