[U-Boot] [PATCH 1/4] wandboard: Set fdt based on board_rev and board_name

[Robert Nelson]

On Mon, Jul 10, 2017 at 3:30 PM, Otavio Salvador
<otavio.salvador at ossystems.com.br> wrote:
> On Mon, Jul 10, 2017 at 5:14 PM, Fabio Estevam <festevam at gmail.com> wrote:
>> On Mon, Jul 10, 2017 at 5:04 PM, Otavio Salvador
>> <otavio at ossystems.com.br> wrote:
>>> From: Fabio Berton <fabio.berton at ossystems.com.br>
>>>
>>> New kernel linux-wandboard version 4.1.15_1.1.0_ga changed device tree
>>> name adding board revision on file name. The new names are:
>>>
>>>  - imx6dl-wandboard-revb1
>>>  - imx6dl-wandboard-revc1
>>>  - imx6q-wandboard-revb1
>>>  - imx6q-wandboard-revc1
>>>
>>> This fixes the Wandboard C1 revision device tree files.
>>>
>>> Signed-off-by: Fabio Berton <fabio.berton at ossystems.com.br>
>>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>>> ---
>>>
>>>  include/configs/wandboard.h | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
>>> index 2a6c6fbb70..4291be4068 100644
>>> --- a/include/configs/wandboard.h
>>> +++ b/include/configs/wandboard.h
>>> @@ -105,9 +105,9 @@
>>>                 "fi\0" \
>>>         "findfdt="\
>>>                 "if test $board_name = C1 && test $board_rev = MX6Q ; then " \
>>> -                       "setenv fdtfile imx6q-wandboard.dtb; fi; " \
>>> +                       "setenv fdtfile imx6q-wandboard-revc1.dtb; fi; " \
>>
>> This breaks the usage of mainline kernel as there is no -revc1 suffix
>> in the wandboard dtb files there.
>>
>> linux-wandboard needs to rename the dts files like mainline does:
>>
>> imx6q-wandboard.dtb (for rev C1)
>> imx6q-wandboard-revb1.dtb
>> imx6dl-wandboard.dtb  (for rev C1)
>> imx6dl-wandboard-revb1.dtb
>>
>> If they can't rename their dts, then they would need to carry this
>> patch on their own U-Boot tree.
>
> No problem; I am sending it here so people can look and if there is
> interest possibly help improving Wandboard kernel. We carry this on
> u-boot-fslc fork so it is fine for me.

How do you guys want to do the revd1'?

imx6<>-wandboard-revd1.dtb ?

https://github.com/wandboard-org/linux/commit/e093a1186879eef78d91f22f1e47089565bde8e9

(let's make sure we don't rename the dtb like we did in the revb1 ->
revc1 era, that was shortsighted mess)

Regards,

-- 
Robert Nelson
https://rcn-ee.com/