[U-Boot] [PATCH 00/30] env: Move environment code to use location drivers

Tom Rini trini at konsulko.com
Wed Jul 12 12:24:45 UTC 2017


On Sun, Jul 09, 2017 at 02:52:43PM -0600, Simon Glass wrote:

> The environment code is ripe for improvement in various ways. It has lots
> of duplication and inconsistencies between how things work with different
> environment locations. It does not properly use Kconfig. Error checking
> and handling is patchy.
> 
> This series makes a start at improving things:
> 
> - moves the rest of the CONFIG_ENV_IS_IN_... options to Kconfig

After this, did you do some checks to make sure that everyone was
migrated correctly?  I ask since I had made an attempt a while back to
convert and I found a lot of cases that didn't happen right and ended up
hacking up something to have every target print all of the env related
options to a file (and have buildman save it).  But it might have been..

> - introduces the concept of a location driver for the environment
> - drops some of the duplicated code
> - improves error handling a little (more to be done here)
> - moves code into a new env/ directory
> 
> There is still much more to do:
> - complete Kconfig conversion (e.g. CONFIG_ENV_SIZE)

Because I was converting these parts as well.

Overall the series looks good.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170712/333a4b61/attachment.sig>


More information about the U-Boot mailing list