[U-Boot] [PATCH 06/14] powerpc: Remove unneccessary #ifdefs in reginfo

Wolfgang Denk wd at denx.de
Wed Jul 12 13:07:16 UTC 2017


Dear Christophe Leroy,

In message <a0ecab632c81feb7b40679076a6165ac7050d9b8.1499629706.git.christophe.leroy at c-s.fr> you wrote:
> reginfo command is calling mpc8xx_reginfo(), mpc85xx_reginfo()
> or mpc86xx_reginfo() based on CONFIG_ symbol.
> As those 3 functions can't me defined at the same time, let's
> rename them mpc8xxx_reginfo() to avoid the #ifdefs

This is indeed a tempting idea, but MPC8xx is a totally different
thing than MPC8xxxx, so the chosen name is misleading and should be
avoided.

> Lets all remove the #ifdefs around the U_BOOT_CMD as this
> file is only compiled when CONFIG_CMD_REGINFO is defined

Has this change been tested / verified against all other boards /
architectures?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I will also, for an appropriate fee, certify that  your  keyboard  is
object-oriented,  and  that  the bits on your hard disk are template-
compatible.            - Jeffrey S. Haemer in <411akr$3ga at cygnus.com>


More information about the U-Boot mailing list