[U-Boot] [PATCH] MIPS: bootm: Fix broken boot_env_legacy codepath

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Wed Jul 12 20:33:43 UTC 2017



Am 11.07.2017 um 17:47 schrieb Zubair Lutfullah Kakakhel:
> This patch fixes 2 bugs introduced by the following commit
> 
> 2bb5b63 MIPS: bootm: rework and fix broken bootm code
> 
> The CONFIG_IS_ENABLED macro prepends 'CONFIG_' Hence, remove CONFIG_
> from CONFIG_MIPS_BOOT_ENV_LEGACY usage.
> 
> Also, 2bb5b63 reworks bootm so that linux_env_legacy runs before
> linux_cmdline_legacy. However, linux_env_legacy depends on
> linux_cmdline_legacy running first as linux_cmdline_init initialilzes
> linux_argp which linux_env_legacy later depends on during its
> initialization.
> 
> Reorder the code so that linux_cmdline_legacy runs before
> linux_env_legacy.
> 
> Signed-off-by: Zubair Lutfullah Kakakhel <Zubair.Kakakhel at imgtec.com>
> 
> ---
> Found this while working on SEAD3 u-boot patches (which are not upstream
> yet)
> ---
>  arch/mips/lib/bootm.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

thanks for fixing. Applied to u-boot-mips/master.

-- 
- Daniel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170712/d0eb31d6/attachment.sig>


More information about the U-Boot mailing list