[U-Boot] [PATCH] tools: buildman: prevent trying to use the working directory as build dorectory

Simon Glass sjg at chromium.org
Thu Jul 13 19:09:58 UTC 2017


On 5 July 2017 at 01:34, Lothar Waßmann <LW at karo-electronics.de> wrote:
> When the U-Boot base directory happens to have the same name as the
> branch that buildman is directed to use via the '-b' option and no
> output directory is specified with '-o', buildman happily starts
> removing the whole U-Boot sources eventually only stopped with the
> error message:
> OSError: [Errno 20] Not a directory: '../<branch-name>/boards.cfg
>
> Add a check to the builderthread.Mkdir function to verify that the
> path it tries to create does not match the current working
> directory.
>
> Signed-off-by: Lothar Waßmann <LW at KARO-electronics.de>
> ---
>  tools/buildman/builderthread.py | 4 ++++
>  1 file changed, 4 insertions(+)

That's nasty, thanks for the fix.

But this is being done inside each thread so I'm not sure how this
will be reported, or whether buildman will stop correctly.

Can the check happen before the build even starts, perhaps? E,g, in builder.py?

Regards,
Simon


More information about the U-Boot mailing list