[U-Boot] [PATCH] net: Mark the ip_udp_hdr struct as packed

Tom Rini trini at konsulko.com
Tue Jul 18 02:35:28 UTC 2017


On Mon, Jul 17, 2017 at 11:29:39AM +0200, Maxime Ripard wrote:
> On Wed, Jul 12, 2017 at 04:37:43PM +0200, Dr. Philipp Tomsich wrote:
> > 
> > > On 12 Jul 2017, at 16:34, Maxime Ripard <maxime.ripard at free-electrons.com> wrote:
> > > 
> > > The -mno-unaligned-access flag used on ARM to prevent GCC from generating
> > > unaligned accesses (obviously) will only do so on packed structures.
> > > 
> > > It seems like gcc 7.1 is a bit stricter than previous gcc versions on this,
> > > and using it lead to data abort for unaligned accesses when generating
> > > network traffic.
> > > 
> > > Fix this by adding the packed attribute to the ip_udp_hdr structure in
> > > order to let GCC do its job.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime.ripard at free-electrons.com>
> > > —
> > 
> > Reviewed-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> 
> I'm not exactly sure who is supposed to merge patches touching
> include/ ? Tom?

I'd like Joe to chime in, since it's net related.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170717/8e52121a/attachment.sig>


More information about the U-Boot mailing list