[U-Boot] [PATCH v2 8/9] rockchip: use debug() instead of printf when back to bootrom

Simon Glass sjg at chromium.org
Tue Jul 18 14:00:25 UTC 2017


Hi Andy,

On 12 July 2017 at 20:30, Andy Yan <andy.yan at rock-chips.com> wrote:
> printf will increase the code size more than 1kb, but platform
> like rk3036 has no enough space for it.
>
> Signed-off-by: Andy Yan <andy.yan at rock-chips.com>
> ---
>
> Changes in v2: None
>
>  arch/arm/mach-rockchip/bootrom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/bootrom.c b/arch/arm/mach-rockchip/bootrom.c
> index da36f92..ba34c35 100644
> --- a/arch/arm/mach-rockchip/bootrom.c
> +++ b/arch/arm/mach-rockchip/bootrom.c
> @@ -10,7 +10,7 @@
>  void back_to_bootrom(void)
>  {
>  #if defined(CONFIG_SPL_LIBGENERIC_SUPPORT) && !defined(CONFIG_TPL_BUILD)
> -       printf("Returning to boot ROM...");
> +       debug("Returning to boot ROM...");
>  #endif
>         _back_to_bootrom_s();
>  }
> --
> 2.7.4
>
>

This is nice for seeing what went wrong when the return does not work.
Could we use puts() instead perhaps?

Regards,
Simon


More information about the U-Boot mailing list