[U-Boot] [RFC PATCH] common: board_f: Make reserve_mmu a weak function

Simon Glass sjg at chromium.org
Tue Jul 18 14:01:05 UTC 2017


Hi Michal,

On 13 July 2017 at 06:50, Michal Simek <michal.simek at xilinx.com> wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
>
> Make reserve_mmu a weak so that it provides an option
> to customize this routine as per platform need

Why do you need this? Can we instead have the generic code do the
right thing? Or can we use reserve_arch() to handle this?

>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
> ---
>
>  common/board_f.c | 2 +-
>  include/common.h | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/common/board_f.c b/common/board_f.c
> index 2cdd12a503ae..09f0fbfb6c96 100644
> --- a/common/board_f.c
> +++ b/common/board_f.c
> @@ -340,7 +340,7 @@ static int reserve_round_4k(void)
>  }
>
>  #ifdef CONFIG_ARM
> -static int reserve_mmu(void)
> +__weak int reserve_mmu(void)
>  {
>  #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF))
>         /* reserve TLB table */
> diff --git a/include/common.h b/include/common.h
> index 1a98512ab618..ce4c92015928 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -286,6 +286,7 @@ void board_show_dram(phys_size_t size);
>   */
>  int arch_fixup_fdt(void *blob);
>
> +int reserve_mmu(void);
>  /* common/flash.c */
>  void flash_perror (int);
>
> --
> 1.9.1
>


More information about the U-Boot mailing list